fboucquez / symbol-bootstrap

A tool that allows you to quickly configure and setup Symbol testnets and nodes.
Apache License 2.0
47 stars 28 forks source link

[hot-fix] renewCertificates on released 1.1.2 #372

Closed fboucquez closed 2 years ago

fboucquez commented 2 years ago

The renewCertificates command created on version 1.1.2 doesn't work when the certificates were created using an old version of bootstrap.

To replicate the bug;

npm install -g symbol-bootstrap@1.1.0
symbol-bootstrap config -p mainnet -a dual --noPassword --reset

npm install -g symbol-bootstrap@1.1.2
echo 'certificateExpirationWarningInDays: 376' > custom-preset.yml  # Old way of forcing expiration
symbol-bootstrap renewCertificates --noPassword -c custom-preset.yml  # Raises an error!

This hotfix fixes that. Try.

npm install -g symbol-bootstrap@1.1.3-alpha-202201201146 # This branch alpha
echo 'certificateExpirationWarningInDays: 376' > custom-preset.yml  # Old way of forcing expiration
symbol-bootstrap renewCertificates --noPassword -c custom-preset.yml   # Certificate renewed!

Another way to renew with the new --force,

symbol-bootstrap renewCertificates --noPassword --force 

Once merged, I'll release this hotfix 1.1.3. Note that the dev branch won' be released on 1.1.3, those fixes would be for the next 1.1.4 (or maybe 1.2.0 version)

It includes:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication