search

fboulnois / stable-diffusion-docker

Run the official Stable Diffusion releases in a Docker container with txt2img, img2img, depth2img, pix2pix, upscale4x, and inpaint.
GNU Affero General Public License v3.0
735 stars 127 forks source link

refactor: expose parse_arg func #76

Closed boriselec closed 11 months ago

boriselec commented 1 year ago

When using this image as base image it is useful to have args parser exposed

fboulnois commented 1 year ago

I don't see a tremendous advantage to doing this. Can you explain your use case?

boriselec commented 1 year ago

Basically i want to do this: https://github.com/boriselec/stable-diffusion-server/blob/69c785df1349f35e0d0f52e7235e665de7a8ecb0/server.py#L68 https://github.com/boriselec/stable-diffusion-server/blob/69c785df1349f35e0d0f52e7235e665de7a8ecb0/server.py#L27

Get args on startup and then modify prompt on each request

fboulnois commented 11 months ago

Since this project has slowed down, I've decided to accept external contributions. I am using your PR as a test of this approach. I hope this works for you, and you should be credited appropriately.

Thank you for your PR!

fboulnois commented 11 months ago

@boriselec , one final question, sorry for the annoyance. I added a CONTRIBUTING.md guide and tried to make it as brief as possible, but added a Developer Certificate of Origin section to ensure this project can actually use PRs that are submitted to it. Since your PR came in before this change, do you agree to the Developer Certificate of Origin?