fboundy / ha_solis_modbus

YAML file for reading Solis Hybrid Inverter directly with HA native modbus
MIT License
50 stars 7 forks source link

Home Assistant version 23.20.0 Modbus Keyword "Count" depreciation. #17

Closed nilremgithub closed 8 months ago

nilremgithub commented 9 months ago

It seems the keyword count no longer supported for the data types int16 or uint16 or int32 or uint32 in the solis.yaml file. Further info here: https://github.com/home-assistant/core/issues/101421

mrstevefay commented 9 months ago

Is there a fix for this we can implement?

lorrainem77 commented 9 months ago

In the solis yaml file (or wherever you have added the contents of that file), find all "count:" lines and either put a # in front of it (e.g. #count: 1) or just remove the line

fboundy commented 9 months ago

Yes, that’s correct. Will update the repo when I get a minute On 16 Oct 2023 at 10:31 +0100, lorrainem77 @.***>, wrote:

In the modbus yaml file, find all "count:" lines and either put a # in front of it (e.g. #count: 1) or just remove the line — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Paulholloway commented 8 months ago

I'm genuinely putting off ever doing another core update... This is the second time in a row that they've broken modbus!

fboundy commented 8 months ago

Closed with release 2.0.0

joeczucha commented 8 months ago

Closed with release 2.0.0

Just a heads up that where you've done a find/replace on count: you've also caught lazy_count: so now your solis.yaml is reading: lazy_error_# count: 5 and throwing errors.

Otherwise, great project :)

fboundy commented 8 months ago

Doh! That’ll teach me. Will get it fixed asap. On 25 Oct 2023 at 13:08 +0100, Joe Czucha @.***>, wrote:

Closed with release 2.0.0 Just a heads up that where you've done a find/replace on count: you've also caught lazy_count: so now your solis.yaml is reading: lazyerror# count: 5 and throwing errors. Otherwise, great project :) — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you modified the open/close state.Message ID: @.***>

fboundy commented 8 months ago

Now fixed