fboundy
commented
3 days ago Definitely! Please go ahead and submit the PR On 1 Jul 2024 at 14:42 +0100, Craig Callender @.***>, wrote:
Not really a feature request as I've already done it. But I'm curious, @fboundy, if you'd be interested in a pull request with the necessary config and documentation to get pv_opt working with the solis-sensor and solis-control integrations. My Solis inverter's datastick isn't compatible with Solarman - so I've had to go the route of using soliscloud via those integrations/scripts. There weren't any code changes needed, but quite a lot of fiddling to get the configuration reading the correct sensors from the solis-sensor integration and then some automation fiddling to get pv_opt's data into the solis-control script. Like I said, I'm happy to do the PR - I just didn't want to go through all the work of writing it up if you're not open to it going in alongside this repo. In which case I can fork this repo and host it there. Thanks! And thanks for all this hard work! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>
CraigCallender
Not really a feature request as I've already done it. But I'm curious, @fboundy, if you'd be interested in a pull request with the necessary config and documentation to get pv_opt working with the solis-sensor and solis-control integrations. My Solis inverter's datastick isn't compatible with Solarman - so I've had to go the route of using soliscloud via those integrations/scripts. There weren't any code changes needed, but quite a lot of fiddling to get the configuration reading the correct sensors from the solis-sensor integration and then some automation fiddling to get pv_opt's data into the solis-control script.
Like I said, I'm happy to do the PR - I just didn't want to go through all the work of writing it up if you're not open to it going in alongside this repo. In which case I can fork this repo and host it there.
Thanks! And thanks for all this hard work!