search

fbradyirl / openwrt-luci-rpc

Other
34 stars 22 forks source link

Fix tox in github actions and also test py38 #46

Closed pdecat closed 3 years ago

pdecat commented 3 years ago

Without this change, tox does nothing in github actions jobs: https://github.com/fbradyirl/openwrt-luci-rpc/pull/45#issuecomment-791915919

And this PR also tests with python 3.8 which is the currently supported version by Home Assistant.

pdecat commented 3 years ago

With this change, tox actually runs the unit tests: https://github.com/fbradyirl/openwrt-luci-rpc/pull/46/checks#step:6:50

  Ran 8 tests in 0.005s
pdecat commented 3 years ago

Oops, I need to alter the github actions workflow to not try and upload the same package twice to pypi now that there is more than one python version (py37 & py38):

HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
File already exists. See https://pypi.org/help/#file-name-reuse for more information.

https://github.com/fbradyirl/openwrt-luci-rpc/runs/2095813523?check_suite_focus=true#step:8:22