search

fbradyirl / openwrt-luci-rpc

Other
34 stars 22 forks source link

Proposed fix for issue #37 #41 incl. legacy support #53

Closed floriangeigl closed 2 years ago

floriangeigl commented 2 years ago

Basically the same fix as mentioned in https://github.com/fbradyirl/openwrt-luci-rpc/pull/41, but considering the concerns of @fbradyirl mentioned here.

Does this sound better @fbradyirl ? Would love to get this in :) Also it's 2y later and most people will have moved to OpenWRT 18.+.

floriangeigl commented 2 years ago

awesome - that was super-fast @fbradyirl 🚀 thanks so much - have a great sunday my friend 👋

fbradyirl commented 2 years ago

No worries. Thanks for the fix. I will try and release a new build this week and perhaps someone can open a PR to get it added to Home Assistant.

floriangeigl commented 2 years ago

perfect - I'm already on that too :) I'll include it in this PR for homeassistant.

fbradyirl commented 2 years ago

Ok v1.1.12 is released now.

floriangeigl commented 2 years ago

amazing 🚀 thx so much @fbradyirl 🙏