warning 'open to everyone' still there when defining approved_domains - Githubissues

fbradyirl / webex_bot

Python package for a Webex Bot based on websockets.

MIT License

68 stars 44 forks source link

warning 'open to everyone' still there when defining approved_domains #7

Closed jseynaev-cisco closed 3 years ago

jseynaev-cisco commented 3 years ago

Webex Bot version: latest pip
Python version: 3.8
Operating System: windows/docker

Description

Starting the bot, limited to my domain, still displays the warning

What I Did

bot = WebexBot(
    teams_bot_token=os.getenv("WEBEX_TEAMS_ACCESS_TOKEN", BEARER_TOKEN),
    approved_domains=['mydomain.com'])

Fix

problem is with line

if len(self.approved_users) == 0 and len(self.approved_users) == 0:

pretty sure it should not be 'users' twice ;-)

fbradyirl commented 3 years ago

Thanks for highlighting!