search

fbrctr / fabricator

A tool for building website UI toolkits and style guides
http://fbrctr.github.io/
MIT License
1.11k stars 124 forks source link

Add Keyboard Shortcut for Menu #229

Closed jonorherrington closed 8 years ago

jonorherrington commented 8 years ago

Thinking through #220 i thought one way to rectify this UX issue would be to add a keyboard shortcut to the menuToggle. By doing this you are able to toggle the menu open and closed without having to scroll all the way to the top to press the menu button. The key code that I used was CTRL + m. I thought this made the most sense and was the least obtrusive. What do you think?

jonorherrington commented 8 years ago

Any thoughts on this @LukeAskew?

LukeAskew commented 8 years ago

Sorry this one dropped off my radar. Just checked it out and it looks good. Only thing is the whitespace...fabricator uses tabs. Make the update and should be good to merge.

jonorherrington commented 8 years ago

That's weird ... i use editorconfig on all projects ... and pulled this down as a fresh instance. Sorry I don't know what happened. Will try again.

jonorherrington commented 8 years ago

Ahh I know what happened ... I copied it from another project where we had to update the .editorconfig to meet some code requirements. Problem should be fixed now @LukeAskew. Thanks!

LukeAskew commented 8 years ago

:cake:

jonorherrington commented 8 years ago

:clap: