search

fbreckle / go-netbox

Package netbox provides an API client for DigitalOcean's NetBox IPAM and DCIM service.
Other
1 stars 22 forks source link

CustomFields: not omitempty for required option #12

Closed chapsuk closed 2 years ago

chapsuk commented 2 years ago

Sorry, I have problems with make generate command :

image

Made this changes manually

fbreckle commented 2 years ago

Yes, I got these changes, too. I pushed the client (including the MANY validation changes) to the branch https://github.com/fbreckle/go-netbox/tree/feature/customfields_no_omitempty

It contains your fix via https://github.com/fbreckle/go-netbox/commit/d49cfef38bfd1d8ec4f7613e4f3900e790569122#diff-3d114d99cf722de411abb4e7720d4e55ec1633a48d966b37c48ae692f10329feR74-R75

Please try, if this client works for the problem with the "required" tag. I hope that the new validation code does not pose any problems.

chapsuk commented 2 years ago

https://github.com/fbreckle/go-netbox/commit/d49cfef38bfd1d8ec4f7613e4f3900e790569122#diff-3d114d99cf722de411abb4e7720d4e55ec1633a48d966b37c48ae692f10329feR74-R75 works fine me, thanks!