search

fbreitwieser / sankeyD3

D3 Sankey Network Graphs from R
67 stars 27 forks source link

use d3r? #1

Closed timelyportfolio closed 6 years ago

timelyportfolio commented 7 years ago

Thanks so much for the invite to contribute. I am slammed for the next month but still hope to be able to play, experiment, test, and add. Have you seen d3r? I think it offers several advantages especially in the igraph -> d3 conversion.

fbreitwieser commented 7 years ago

d3r, that's a great package idea! Thanks @timelyportfolio , I'll be using it.

timelyportfolio commented 7 years ago

Would you be open to using d3r for the d3 dependencies? Here is where I switched sunburstR to use d3R instead of yaml https://github.com/timelyportfolio/sunburstR/commit/be5361ddba9b68b27389a2aca03293c7806cc95f.

fbreitwieser commented 7 years ago

Thanks for the link to the change, it's really straightforward. And nice that it's on CRAN! I definitely am, I think it's a good idea to have the dependency in the package. Does using d3r also solve #4 ?