fbrinker / docker-tileboard

Docker Container for TileBoard: "A simple yet highly configurable Dashboard for HomeAssistant"
https://hub.docker.com/r/fbrinker/tileboard
MIT License
1 stars 1 forks source link

feat(RELEASE): allow overriding build.sh #5

Closed akloeckner closed 3 years ago

akloeckner commented 3 years ago

I'm experimenting with GitHub workflows and found the current setup has some minor flaws that prevent building the images, if the current release is already compiled and available on Docker hub. This is necessary, e.g., when requesting a build manually, or if only the Dockerfilehas changed. This PR fixes those issues in the following way:

build.sh is still aborted before changing Dockerfile, so people can run it locally without modify the git repo. .arg may be changed, because it is .gitignored.

Here's an example of how to use the changed script in a GitHub workflow: https://github.com/akloeckner/TileBoard-docker/blob/26e167b4d57bbca1913f75e3f100aa22babf3973/.github/workflows/release.yml#L32

There should be no impact on current build setups. (Other than a somewhat cryptic echo of the release URL.)

fbrinker commented 3 years ago

Thank you, good idea :)