search

fbsamples / fbinstant-samples

Sample projects for the Facebook Instant Games platform
Other
257 stars 139 forks source link

added build & endbuild tags for gulp-html-replace to work properly #14

Closed kayrules closed 5 years ago

kayrules commented 5 years ago

from gulp-html-replace documentation, we need to have the build & endbuild tags for it to work properly.

<!-- build:<name> -->
Everything here will be replaced
<!-- endbuild -->
facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

kayrules commented 5 years ago

this PR is related to this issue

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

mingcaocao commented 5 years ago

@kayrules This is awesome! Thanks for contributing!