search

fbsamples / messenger-bot-samples

Messenger Bot Samples
Other
555 stars 441 forks source link

fix knex migration #42

Closed gpwclark closed 5 years ago

gpwclark commented 5 years ago

The knex/src/migrate/Migrator.js doesn't pass a promise in, so the migration fails with:

migration file "20170331112237_lists.js" failed migration failed with error: Cannot read property 'all' of undefined

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

embee8 commented 5 years ago

Thanks @gpwclark! Would you mind amending your PR to also remove the Promise from the 'down' section before I merge?

https://github.com/fbsamples/messenger-bot-samples/blob/f806668b40b0cb6f8c9557b568081dd3ace383bc/chat-extensions/db/migrations/20170331112237_lists.js#L37

gpwclark commented 5 years ago

woops, very sloppy... yeah.

sunz7 commented 5 years ago

Thanks for the fix! It saved me a lot of time