fbsamples / original-coast-clothing

Sample Messenger App - Original Coast Clothing
https://fb.me/get-sample-oc
Other
201 stars 229 forks source link

**ENHANCEMENT** — Update i18n and eslint to remove vulnerabilites #73

Closed Barbog closed 3 years ago

Barbog commented 3 years ago

to remove vulnerabilities present in minimist, updated packages:

tested by deploying to Heroku and testing features. i18n features still functioned as expected

Is your pull request related to a problem? Please describe

This addresses the current vulnerabilities in the currently used minimist packages

Describe the solution you'd like

Updates the packages dependent on minimist to update the vulnerable package

Test plan

Installed in Heroku, hooked up to a Messenger app, trialed the functionality of modified packages (notably i18n)

Checklist

facebook-github-bot commented 3 years ago

@Barbog merged this pull request in fbsamples/original-coast-clothing@41f5e615182c08faf6bb950f4813e979a4ac62b6.