fbucek / sqlxinsert

MIT License
18 stars 9 forks source link

feat: allow any and all executors #8

Closed jayy-lmao closed 1 year ago

jayy-lmao commented 1 year ago

Hey there @fbucek!

Feel free to toss this out / suggest changes. I was recently finding a need for this at work, and had to fork in order for it to fit the needs of our project.

There were a couple of major changes, happy to open a PR with any combination of them instead of this PR.

Like I said, was just trying to accelerate progress on a work project. If you want any of it I can spend a bit of my own time tidying it up / making any changes you want etc.

I've tested it my project and it has worked fine.

fbucek commented 1 year ago

Thanks for contribution.

1) Eyre can be removed from all the code. 2) Executor instead of pool is much better. 3) Unfortunatelly insert without return is not ok. But maybe adding another method insert_get::<Car> would be fine. 4) Update method is ok, I do not now whether it will be usefull but it is just a few lines so I would keep it.

I will look into in this week I hope.