fbucek / sqlxinsert

MIT License
18 stars 9 forks source link

solve breaking change in insert method #9

Open fbucek opened 1 year ago

fbucek commented 1 year ago

Method insert now without generic parameter not returning struct.

What is better approach. Have breaking change with insert method and new method insert_get::<T> which will cause breaking change or rename insert without generic parametr and add new method without return. e.g. insert_nr ( no return ) insert::<T> and insert_noret

Looks to me, that this with breaking change looks ok

let new_car = NewCar { name: "Test" };
let car = new_car.insert_get::<Car>("cars").unwrap();
new_car.insert("cars").unwrap();

Then do not forget to update documentation.