search

fc-thrisp-hurrata-dlm-graveyard / engine-defunct

Engine is a core to drive a Go web framework.
MIT License
2 stars 2 forks source link

Hanging Panic #3

Closed 1xch closed 10 years ago

1xch commented 10 years ago

When using Engine with Flotilla, a (forced) panic will happen once but page reloads will cause everything to "hang", i.e. browser will spin waiting for a response that never arrives.

1xch commented 10 years ago

Appears to be centered here: https://github.com/thrisp/engine/blob/develop/httpstatus.go#L137, with SendSignal.

Changing:

c.engine.SendSignal(sig)

to 

go c.engine.SendSignal(sig)

seems to fix the issue for now.

It is a bottom line issue of understanding Go channels, and integrating them with Engine & Engine working inside other packages. And, this needs to be done at any point SendSignal is called or it will hang.