search

fcambus / rrda

REST API allowing to perform DNS queries over HTTP
https://www.statdns.com
BSD 2-Clause "Simplified" License
221 stars 56 forks source link

Use netcgo build #10

Closed soullivaneuh closed 8 years ago

soullivaneuh commented 8 years ago

Fixes #8.

Related external issue: https://github.com/miekg/dns/issues/308

soullivaneuh commented 8 years ago

Is this a joke?

Absolutely not, I'm trying to solve issue with locally defined host (/etc/hosts).

I'm trying to understand and contribute even if I'm not a Golang expert.

Having opinions and advises would be more encouraging than an asking about a joke.

fcambus commented 8 years ago

Using the pure Go resolver by default is the intended behavior.

The change you are proposing has severe implications :

1) It breaks the default for the installed userbase 2) CGO makes cross compilation extremely hard / borderline impossible 3) It means that glibc resolver will be used on most Linux systems

Regarding the third point, in light of CVE-2015-7547, I don't think I need to explain why this is a terrible idea.

soullivaneuh commented 8 years ago

Better explanation, thanks.

In this case, could you please reopen #8?

I can ensure this issue still exists for internal docker dns and can/should be resolved. Maybe you or another contributor have a solution for that.