Truncated Message Handling

fcambus / rrda

REST API allowing to perform DNS queries over HTTP

https://www.statdns.com

BSD 2-Clause "Simplified" License

223 stars 56 forks source link

Truncated Message Handling #11

Closed andrewtj closed 8 years ago

andrewtj commented 8 years ago

If the TC bit is set dns.Exchange() will return dns.ErrTruncated which is not caught in resolve(). Tested by looking up _http._tcp.dns-sd.org. IN PTR.

fcambus commented 8 years ago

Indeed, it seems dns.Exchange() behavior was changed a couple months ago.

Thanks for reporting this, it should be fixed now.

jmunson commented 4 years ago

It looks like this behavior was reverted in https://github.com/miekg/dns/issues/814

Now rrda fails to build as a result:

../../go/src/github.com/fcambus/rrda/rrda.go:125:19: undefined: dns.ErrTruncated

fcambus commented 4 years ago

Indeed, thanks for reporting this, I reverted to the previous behavior.

RRDA should now build again.