Subscribe newsletter page with a video play icon

fccn / nau-richie-site-factory

Site factory to build NAU web sites based on https://github.com/openfun/richie

https://www.nau.edu.pt/

GNU Affero General Public License v3.0

0 stars 1 forks source link

Subscribe newsletter page with a video play icon #196

Closed igobranco closed 6 months ago

igobranco commented 9 months ago

When we change the video player to be lazy and add a additional step so we don't load the iframe even the user don't want to play the video #157 #167, this new feature had the impact of the "Subscribe to newsletter" page is using the video player component to iframe the e-goi.

https://www.nau.edu.pt/en/newsletter/

sandroscosta commented 8 months ago

After an initial analysis, I propose 2 solutions to this issue:

Have a flag on video_player_plugin to disable the playbutton;
Create a new embeddable_plugin to allow the placement of external contents. This would apply directly to this situation and wouldn't change or create complex behaviour on the video_player_plugin.

Last, but not least, there's a https://github.com/django-cms/djangocms-snippet that we can use to place HTML/JS blocks on the site.

igobranco commented 8 months ago

I think we should use the 2nd option. We should separate the videos from the HTML/JS blocks. I think we should test the installation of the plugin djangocms-snippet on this repository.

sandroscosta commented 7 months ago

I'll test out the djangocms-snippet.

sandroscosta commented 6 months ago

djangocms_snippet works as intended and solves the issue. Will push a PR to install it on nau-site-factory

igobranco commented 5 months ago

Snippet that we should configure:

<iframe
    title="Newsletter NAU"
    src="https://mkt.nau.edu.pt/w/nereT0Sech5wqfQLy44e1920803de!uid"
    allowfullscreen=""
    style="width: 100%; height: 20rem;"
    frameBorder="0">
</iframe>

igobranco commented 5 months ago

Changed in production! https://www.nau.edu.pt/pt/newsletter/