search

fcdimitr / sgtsnepi

Swift Neighbor Embedding of Sparse Stochastic Graphs
GNU General Public License v3.0
19 stars 10 forks source link

Build failing with most recent OpenCilk version #14

Open Thodoris1999 opened 11 months ago

Thodoris1999 commented 11 months ago

In the newest OpenCilk version (2.0) the header cilk/reducer_opadd.h does not exist which causes the build to fail. As far as I know opencilk.org does not distribute opencilk version 1.0 unfortunately.

Apparently reducer_opadd has been deprecated https://chromium.googlesource.com/native_client/nacl-gcc/+/ng/master/libcilkrts/include/cilk/reducer.h#625. The docs also mention a different method to perform reduction https://www.opencilk.org/doc/reference/reducers/.

pitsianis commented 11 months ago

This is an easy change, we should fix it. Long term, we are going to a pure Julia implementation, to make it easy to distribute without a dependence to OpenCilk.

fcdimitr commented 3 days ago

:wave: @Thodoris1999 could you try the v3.0.0 branch that includes the changes from #15? This branch should compile with OpenCilk version 2.0

Thank you!

Thodoris1999 commented 2 days ago

./test_modules now works with most recent opencilk version