search

fchierad / PRD

Repository to store ECMAScript code used in workflows created with the product NetIQ Identity Manager.
MIT License
2 stars 2 forks source link

Nomenclature #19

Closed bshefflette closed 6 years ago

bshefflette commented 6 years ago

I am having to visit the names and paths of these methods several times during development. Can we discuss having more consistency w/ naming & which module some functions are a part of? e.g. PRD.IDVget() PRD.web.form.getValue() These stem from module.IDVault.get & module.form.getValue, that consistency of those stemming objects was nice, worth discussing?

fchierad commented 6 years ago

worth discussing - yes.

Initial reason for the IDVget and IDVglobalQuery naming was to enforce different naming from the RBPM product's shipping functions. That decision was made to avoid confusion with the product's shipping methods, since the ones in this module have different behavior from the shipping ones.

Imagine having to remember a different set of behaviors/return types for things that are named exactly the same - I'd expect that to cause more confusion for end users of the module.

The from and field portion are direct exports of the native module, just exposed on a public scope. That is why their function names and behaviors stayed the same.