6.1-using-word-embeddings - There seems to be a bug

fchollet / deep-learning-with-python-notebooks

Jupyter notebooks for the code samples of the book "Deep Learning with Python"

MIT License

18.61k stars 8.63k forks source link

6.1-using-word-embeddings - There seems to be a bug #145

Open AI-Guru opened 4 years ago

AI-Guru commented 4 years ago

Hello,

I love this collection of notebooks! The book is great!

One thing. When using the GloVe embeddings, there seems to be a flaw in the implementation: When creating the embedding matrix, the indices should be shifted by 3. Doing so results in a 20% accuracy increase on validation data.

Best, Tristan

fangxuehouwuming commented 2 years ago

Hi, I am a beginner. I don't know what does 'the indices should be shifted by 3' mean? Could you tell me how to do this and why? Thank you!