fcitx / fcitx5-chewing

17 stars 7 forks source link

Build failure with libchewing 0.9.0-rc.1 as chewingio.h was removed #23

Closed yan12125 closed 3 months ago

yan12125 commented 3 months ago

chewingio.h is removed in https://github.com/chewing/libchewing/pull/567 (part of libchewing 0.9.0-rc.1). As a result, build fails with:

FAILED: src/CMakeFiles/chewing.dir/eim.cpp.o 
/usr/bin/c++ -DFCITX_GETTEXT_DOMAIN=\"fcitx5-chewing\" -DFCITX_INSTALL_LOCALEDIR=\"/usr/share/locale\" -Dchewing_EXPORTS -isystem /usr/include/Fcitx5/Core -isystem /usr/include/Fcitx5/Config -isystem /usr/include/Fcitx5/Utils -isystem /usr/include/chewing -Wall -Wextra -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -fexceptions         -Wp,-D_FORTIFY_SOURCE=3 -Wformat -Werror=format-security         -fstack-clash-protection -fcf-protection         -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -Wp,-D_GLIBCXX_ASSERTIONS -g -ffile-prefix-map=/build/fcitx5-chewing/src=/usr/src/debug/fcitx5-chewing -flto=auto -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -MD -MT src/CMakeFiles/chewing.dir/eim.cpp.o -MF src/CMakeFiles/chewing.dir/eim.cpp.o.d -o src/CMakeFiles/chewing.dir/eim.cpp.o -c /build/fcitx5-chewing/src/fcitx5-chewing/src/eim.cpp
In file included from /build/fcitx5-chewing/src/fcitx5-chewing/src/eim.cpp:8:
/build/fcitx5-chewing/src/fcitx5-chewing/src/eim.h:11:10: fatal error: chewingio.h: No such file or directory
   11 | #include <chewingio.h>
      |          ^~~~~~~~~~~~~

Before chewingio.h is removed, it is already included via chewing.h. I think #include <chewingio.h> can be simply removed eim.h as chewing.h is already included there?

https://github.com/fcitx/fcitx5-chewing/blob/5ad232a6e4b094fb1ede33b04432d030c6695ad5/src/eim.h#L10-L11