search

fcitx / fcitx5-cskk

SKK input method plugin for fcitx5 that uses LibCSKK
GNU General Public License v3.0
40 stars 3 forks source link

Use your own name for input context property. #1

Closed wengxt closed 3 years ago

wengxt commented 3 years ago

https://github.com/naokiri/fcitx5-cskk/blob/3773af3b0ef697502d98e5f4ab6afb9d1c391afb/src/cskk.cpp#L26

I know you probably take fcitx5-skk as a reference, but the input context property name need to be globally unique. This would cause problem if cskk and skk are loaded at the same time since they both use "skkState".

It is defined as a meaningful string instead of a random string just in case any external module want to reuse it, but usually the name itself doesn't matter.

naokiri commented 3 years ago

Thanks a lot! I didn't know how it work deep inside.

naokiri commented 3 years ago

Fixed on latest master.