drakkan
commented
2 months ago Hi,
I just tested using lftp installed locally instead of in Docker and I cannot replicate
$ lftp -p 2121 127.0.0.1
lftp 127.0.0.1:~> set ssl:verify no
lftp 127.0.0.1:~> user a password
lftp a@127.0.0.1:~> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferred
lftp a@127.0.0.1:/> put /tmp/test.txt
5 bytes transferredIn the logs I always have this
{"level":"debug","time":"2024-07-15T10:46:59.863","sender":"ftpserverlib","server_id":"FTP_0","clientId":"5","writtenBytes":"5","message":"Stream copy finished"}P.S. I used SFTPGo instead of your reproducer
ale-rinaldi
fclairamb
Hello,
I recently used ftpserverlib to migrate an old setup based on PureFTP. Everything is good except some scripts based on lftp that began to upload 0-byte files without any error.
Doing some tests, I noticed that this happens only when TLS is involved, while there seems to be no issue on a plain connection.
I have a minimal reproducible step-by-step example:
Create an empty folder and enter it
Run
go mod init testCreate a self-signed certificate
Create this main.go file:
import ( "crypto/tls" "fmt" "github.com/fclairamb/ftpserverlib" adapter "github.com/fclairamb/go-log/slog" "github.com/spf13/afero" "log/slog" )
type ServerDriver struct{}
func (driver *ServerDriver) ClientConnected(cltContext ftpserver.ClientContext) (string, error) { return "Welcome", nil }
func (driver *ServerDriver) AuthUser(_ ftpserver.ClientContext, user, pass string) (ftpserver.ClientDriver, error) { return afero.NewBasePathFs(afero.NewOsFs(), "/tmp"), nil }
func (driver *ServerDriver) PostAuthMessage(_ ftpserver.ClientContext) (string, error) { return "Authenticated", nil }
func (driver *ServerDriver) QuitMessage() string { return "Disconnected from server" }
func (driver *ServerDriver) ClientDisconnected(cc ftpserver.ClientContext) { return }
func (driver ServerDriver) GetSettings() (ftpserver.Settings, error) { return &ftpserver.Settings{ DefaultTransferType: ftpserver.TransferTypeBinary, ListenAddr: fmt.Sprintf("127.0.0.1:21"), PassiveTransferPortRange: &ftpserver.PortRange{ Start: 30000, End: 50000, }, }, nil }
func (driver ServerDriver) GetTLSConfig() (tls.Config, error) { keypair, err := tls.LoadX509KeyPair("cert.pem", "key.pem") if err != nil { return nil, err }
}
func main() { srv := ftpserver.NewFtpServer(&ServerDriver{}) lvl := new(slog.LevelVar) lvl.Set(slog.LevelDebug) logger := slog.New(slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{ Level: lvl, })) srv.Logger = adapter.NewWrap(logger) err := srv.Listen() if err != nil { panic(err) } panic(srv.Serve()) }
docker run -it --rm --network host alpine sh
apk add --no-cache lftp
echo "Test" > test.txt
lftp 127.0.0.1
On lftp side I see: "5 bytes transferred".
On ftpserverlib I see: "level=DEBUG msg="Stream copy finished" clientId=1 writtenBytes=0".
The file /tmp/test.txt on the host has 0 bytes length.
This actually does not always happen, sometimes it fails on first attempt and sometimes after 4 or 5 attempts.
Unfortunately, I'm unable to track down what this depends on or debug it. I'm not blaming ftpserverlib, it may be an lftp problem. I hope someone may point me to the right direction.
Thank you