Add more motivational quotes

fcoterroba / Advice_Me

That's an extension which provides advices every time you need it

GNU General Public License v3.0

3 stars 14 forks source link

Add more motivational quotes #3

Open fcoterroba opened 3 years ago

fcoterroba commented 3 years ago

You can add more motivational quotes adding it to the array on background.js

Clarification: If this issue is assigned to a person, don't worry. I'll make more issues like this. Just please be aware and check all sentences before writing. There should be no repeating phrase as the randomness factor would be lost.

fcoterroba commented 3 years ago

@rahulshawdev You did a PR #5 with 3 commits. Are you interested in having that PR contributing to the hacktoberfest? I can wait for October if you want but assigning the issue to you.

Anyway, the commit #bc49516 and #73355dd are valid but #0a58b09 not because you modified all the text (you changed the quotes, among a few other things).

Remember also that the last quote ALWAYS goes without the comma at the end

d4rkener commented 3 years ago

Yup, I'm interested in contributing to hacktoberfest.

d4rkener commented 3 years ago

I didn't modify all the text, when I click to save on my VS Code, all the thingsautomatically formatted by Prettier. Can you tell me how can I solve that problem??

fcoterroba commented 3 years ago

Yup, I'm interested in contributing to hacktoberfest.

Okay, I'll assign it to you. I'll wait for your final PR in October. If there is no update in mid-October, I will designate it for you so that someone else can participate

I didn't modify all the text, when I click to save on my VS Code, all the thingsautomatically formatted by Prettier. Can you tell me how can I solve that problem??

I do not know the extension you are talking about but the easiest thing would be to copy and paste all the phrases directly without going through the code editor

d4rkener commented 3 years ago

I fix it