search

fcoury / octopi

A Ruby interface to GitHub API v2
http://hasmany.info/2009/4/18/ruby-interface-to-github-api
MIT License
216 stars 47 forks source link

Support Listing of Issues Regardless of State #10

Closed runpaint closed 13 years ago

runpaint commented 15 years ago

The Issues API allows the viewing of either open or closed issues, but not both from the same call. This is silly. We want Issues.find_all(user, repo) to return both open and closed issues; Issues.find_all(user, repo, state) would support limiting by state. Currently, the first invocation assumes state=open.

If develop/develop.github.com/#16 is fixed, we'll stop providing a default for state and this should just work. Otherwise, we may need to make two calls (one for each state) and merge the results. This would only be done in the absence of a state parameter.

radar commented 13 years ago

This is now fixed in 4dbfe0c, sorry for the time lag.