Github API V3 - Githubissues

fcoury / octopi

A Ruby interface to GitHub API v2

http://hasmany.info/2009/4/18/ruby-interface-to-github-api

MIT License

216 stars 47 forks source link

Github API V3 #61

Open jeffWelling opened 13 years ago

jeffWelling commented 13 years ago

Feature request for upgrading to the Github API version 3.

Version 3 has support for editing comments on an issue, while IIUC version 2 does not.

radar commented 13 years ago

Right now I would rather not put work into an API that is unstable. I developed a gem for the StackOverflow API while it was under active development and that was traumatic enough. I am going to wait until they have stabilized the API and then spend some time porting it over. Or you could? The code's there to do it and the changes will most likely be easy.

ivey commented 13 years ago

I'm going to start working on this in ivey/octopi ... help appreciated.

radar commented 13 years ago

Thank you ivey, I see that the API is more developed than when I looked at it last (it now contains repos + users). Hopefully the tests in the current system provide a nice base for the third version. Look forward to seeing what you come up with.

ivey commented 13 years ago

@radar: because github v3 doesn't use token auth, authenticated_with is going to be pretty different. got time to chat on IRC about potential changes and how to handle?

other than auth, i think i have the basics of this ready to go using Issues as a base, and adding additional calls is pretty easy. (i'm using api_smith underneath)

EDIT: Nevermind. I think I have something workable.

radar commented 13 years ago

Howdy,

Yes I'm available for talking any time between 6am-8am and 7pm-10pm Australian Eastern Time. Anywhere in between that, I'd probably be working and randomly available.

Great to hear you've got the basics going :)

On Sunday, 3 July 2011 at 5:47 AM, ivey wrote:

@radar: because github v3 doesn't use token auth, authenticated_with is going to be pretty different. got time to chat on IRC about potential changes and how to handle?

other than auth, i think i have the basics of this ready to go using Issues as a base, and adding additional calls is pretty easy. (i'm using api_smith underneath)

Reply to this email directly or view it on GitHub: https://github.com/fcoury/octopi/issues/61#issuecomment-1490321

ivey commented 13 years ago

OK, I've got the basics of using V3 for Issues (while V2 for everything else) in my ivey/octopi in master. Tests are still failing, but getting there:

94 tests, 160 assertions, 4 failures, 10 errors, 0 skips

Anyone who wants to take a look, especially at generating the rest of the stub json files, feel free.

Couple things of major note:

Issue.search won't work at all w/ API V3 currently. I've asked @technoweenie if that'll change.
V3 does not use token auth, so attempts to do V3 things w/ a token will issue a warning, and then fail. We may try to be better at handling that at some point.

jeffWelling commented 13 years ago

Issue.search won't work at all w/ API V3 currently. I've asked @technoweenie if that'll change.

Do you think you could link to the question (unless it was a private message), I'm also curious about if this will change. Search seems like kind of a non-trivial thing to me.