fcoury / octopi

A Ruby interface to GitHub API v2
http://hasmany.info/2009/4/18/ruby-interface-to-github-api
MIT License
216 stars 47 forks source link

commit details not supported as per README #70

Closed gregwebs closed 12 years ago

gregwebs commented 12 years ago

repo.commits.first.details NoMethodError: undefined method `details' for #Octopi::Commit:0x000000017a2af0

radar commented 12 years ago

I can confirm this bug but I haven't gone as far as to investigate why / how it's happening. Would you be able to do that and submit a pull request with any fix that's necessary? Thanks!

gregwebs commented 12 years ago

The pull would be to delete that example from the README. I thought I would open this ticket instead in case you wanted to attempt some archaeology if you had an idea of where this functionality was deleted (assuming it worked at some point).

On Wed, Oct 19, 2011 at 3:48 AM, Ryan Bigg < reply@reply.github.com>wrote:

I can confirm this bug but I haven't gone as far as to investigate why / how it's happening. Would you be able to do that and submit a pull request with any fix that's necessary? Thanks!

Reply to this email directly or view it on GitHub: https://github.com/fcoury/octopi/issues/70#issuecomment-2454313

radar commented 12 years ago

It would be happening because the GitHub API doesn't return details in commit collections any more. Instead, you have to find the individual commit you want the details for and then do a query on that. I've updated the README in effect.