Closed mikejritter closed 2 years ago
@mikejritter I did a first complete review of your revised PR. In general it looks good. I made some suggestions for improvements, which are already included in my followup PR (https://github.com/fcrepo-exts/fcrepo-camel-toolbox/pull/169).
JIRA Ticket: https://fedora-repository.atlassian.net/browse/FCREPO-3746
What does this Pull Request do?
Adds a Dockerfile for building an image with the camel-toolbox app as well as a docker-compose configuration file for running the camel-toolbox alongside Fedora and other components.
What's new?
How should this be tested?
Run with docker-compose (not 100% functional yet -- see notes):
Additional Notes:
Looking for a little bit of feedback on the docker files:
Also the network setup doesn't exactly seem compatible with the camel-toolbox at the moment as interaction with Fedora is done through localhost and camel connects through the docker hostname (fcrepo). This leads to camel toolbox failing to connect to Fedora as it appears to be getting the url to invoke from the http request.fcrepo.jms.baseUrl
propertyInterested parties
@fcrepo/committers