fcrepo-exts / fcrepo-import-export

Apache License 2.0
15 stars 19 forks source link

Support export for the BeyondTheRepository BagIt profile #135

Closed mikejritter closed 4 years ago

mikejritter commented 4 years ago

Partially resolves (imo): https://jira.lyrasis.org/browse/FCREPO-3176

This adds support for some of the newer additions in both the bagit-profiles-spec and the beyond the repository bagit profile:

I also opted to read in the full bag profile json in BagProfile in anticipation of doing more validation against BagIt Bags, as I think there's some additional opportunity for both the BagIt Profiles and import of BagIt Bags.

For the BagIt Profiles, you'll find requirements mentioned throughout the spec such as:

Every file in Tag-Files-Required must also be present in Tag-Files-Allowed.

This I haven't added yet but could be done either when reading the BagIt Profile json or with the BagConfig validation.

For the Import, it looks like work had been started for validating BagIt Bags before running the Import process itself but had been put on hold. I don't think would be onerous to add support for ensuring a Bag conforms to a profile, but I wanted to keep this PR scoped to export.

awoods commented 4 years ago

@mikejritter : Thanks for this work!

@bbranan : I will be offline the rest of the week. If my comments resolved/addressed before next week and you want to get this merged, feel free. Otherwise, I will approve/merge next week.

bbranan commented 4 years ago

The updates based on comments look good to me. @awoods feel free to merge when you've had a chance to take a look.