Verify bag profiles conform to bagit-profiles-spec

mikejritter commented 4 years ago

Resolves: https://jira.lyrasis.org/browse/FCREPO-3204

Adds validation to the BagProfile to test a profile after it has been loaded
Updates profiles to be conformant with bagit-profiles-spec
- changes for aptrust merged from dart
Tests all profiles under src/main/resources/profiles

As this adds unit tests to BagProfileTest in order to test the bag profiles, testing for this can be done through maven:

mvn -Dtest=BagProfileTest test

or to run the three new tests individually:

mvn -Dtest=BagProfileTest#testAllProfilesPassValidation test
mvn -Dtest=BagProfileTest#testInvalidBagProfile test
mvn -Dtest=BagProfileTest#testInvalidBagProfileSerializationTypo test

mikejritter commented 4 years ago

@awoods I just pushed new commits which should resolve your comments. I was briefly considering refactoring validateProfile since it is now being done within the test class and likely doesn't need to throw an exception, but left it as is.

awoods commented 4 years ago

This should be good to go... once the merge conflict has been resolved.

fcrepo-exts / fcrepo-import-export

Verify bag profiles conform to bagit-profiles-spec #138