Line feed issues prevent install scripts from running correctly on Windows hosts

fcrepo-exts / fcrepo-vagrant

Fedora 4 Vagrant Virtual Machine

26 stars 22 forks source link

Line feed issues prevent install scripts from running correctly on Windows hosts #14

Open dmolesUC opened 9 years ago

dmolesUC commented 9 years ago

Steps to reproduce:

on a windows machine, confirm that vagrant and virtualbox are installed and working
clone the repository using git-bash
cd to the repo directory and run vagrant up

Expected:

installation succeeds

Actual:

somewhere around the Solr installation, a bunch of error messages with \r in them

Analysis:

it looks like the scripts in install_scripts get CRLF line endings when checked out on Windows, and when copied to the virtual machine they still have these line endings.

Proposed fix:

use .gitattributes to force LF endings for these scripts (pull request forthcoming)

philred commented 9 years ago

I can verity this issue.

ruebot commented 9 years ago

@philred could you verify the proposed fix in #15?

philred commented 9 years ago

That didn't work for me. i'm still getting lines such as:

cannot stat ��/vagrant\r/downloads\r/solr-.tgz��

awoods commented 9 years ago

@philred, do you have a patch that works for you? If so, please provide a pull-request.

philred commented 9 years ago

No, i manually used atom to change the line endings to unix.

philred commented 9 years ago

No idea why, but using https://github.com/dmolesUC3/fcrepo4-vagrant works but https://github.com/fcrepo4-labs/fcrepo4-vagrant with the https://github.com/fcrepo4-labs/fcrepo4-vagrant/pull/15 does not work for me.

philred commented 9 years ago

I just tested forking https://github.com/fcrepo4-labs/fcrepo4-vagrant and adding the gitattributes file on a linux box, then push/pull back to windows. This almost worked except localhost:8080/fcrepo didn't show up. I repeated cloning to windows and manually changing the line endings, and that worked.

awoods commented 9 years ago

Something sounds fishy. I wish we had another Windows user lurking on this thread.

philred commented 9 years ago

Further investigation shows that autocrlf = true is automagically converting line endings to CRLF from the LF that vagrant up wants. Edit .gitconfig, set autocrlf = false, and then delete and reclone to make it work. No code changes required, but perhaps a troubleshooting note for windows users would be helpful.

awoods commented 9 years ago

That is great, @philred. Could you please create a "troubleshooting" section to the README and submit as a pull-request? That would be very helpful and appreciated.