fcrepo-exts / migration-utils

An in-development framework for managing data migrations from previous versions to 4.x.

Apache License 2.0

13 stars 29 forks source link

Remove deprecation, javadoc warnings and SimpleIDMapper #118

Closed whikloj closed 4 years ago

whikloj commented 4 years ago

JIRA Ticket: https://jira.lyrasis.org/browse/FCREPO-3458

What does this Pull Request do?

All non-functional changes, I:

updated the JUnit version and fixed some deprecated package names
cleaned up some javadoc misses
removed the deprecated SimpleIDMapper and the one test that referred to it.

How should this be tested?

Should work the same as before.

Interested parties

@fcrepo-exts/committers & @sprater

sprater commented 4 years ago

Still one unchecked cast warning during compile phase:

[INFO] Compiling 20 source files to /home/lcbuser/migration-utils/target/test-classes
[WARNING] /home/lcbuser/migration-utils/src/test/java/org/fcrepo/migration/Example1TestSuite.java:[60,111] unchecked cast
  required: java.util.List<org.fcrepo.migration.ObjectProperty>
  found:    java.util.List<capture#1 of ? extends org.fcrepo.migration.ObjectProperty>

sprater commented 4 years ago

Tested and verified that the warnings are gone. Ready to merge.