search

fcrepo / Fedora-API-Test-Suite

A Standalone testing suite that exercises the requirements in the Fedora API Specification indicating the degree of a server’s compliance with the specification.
Apache License 2.0
3 stars 11 forks source link

Direct container skip #330

Closed gregjan closed 5 years ago

gregjan commented 5 years ago

This code primarily separates direct and indirect container support from other related requirements, including the ldp:constrainedBy header requirement. It ensured that some additional tests are skipped when direct or indirect containers are not supported (Prefer membership). It creates a separate set of tests for the ldp:constrainedBy Link header.

Note: This will require rebase after/if other PRs are accepted.

gregjan commented 5 years ago

There is a lot here and probably several commits that are worthy of discussion. To summarize, several tests resulted in errors for reasons particular to Trellis, but not out of line with the Fedora spec (IMO). So in those cases I have narrowed the tests to focus on the specification. In other cases I have expanded the test code because Trellis requires a more complete RDF body for direct and indirect containers. I also added a less prescriptive Graph assertion method, for testing triple patterns instead of particular SPOs.

gregjan commented 5 years ago

FYI, latest annotated results for Trellis w/PostgreSQL after these adjustments: http://drastic-testbed.umd.edu/static/Fedora-reports/trellis-ext-db/report/testsuite-execution-report.html

gregjan commented 5 years ago

Okay, great! Glad that we identified a spec detail as well. I'm not sure that I can merge this, but let me know if there is more that I can do.

gregjan commented 5 years ago

I'll wait to create my other PR until this merges, since it'll look a lot cleaner after I rebase..