Add "info" option to display detail information of a sport session.

fcrespel / runtastic-export-converter

Command-line tool to convert Runtastic JSON export files to GPX/TCX

MIT License

1 stars 2 forks source link

Add "info" option to display detail information of a sport session. #3

Closed ImfeldC closed 4 years ago

ImfeldC commented 4 years ago

Here my first "pull request", to test general workflow. Is this correct that way?

fcrespel commented 4 years ago

Thanks for the contribution! This is the way ;-) I've added some comments in the code review, please let me know if you'd like to handle them. Any further commit you do will automatically be added to this PR.

ImfeldC commented 4 years ago

Changes published back.

ImfeldC commented 4 years ago

All review findings incorporated.

fcrespel commented 4 years ago

Note that I further simplified ExportConverter.getSportSession() in an additional commit after the merge. Thanks for your work! 👍

ImfeldC commented 4 years ago

Cool! Thanks for accepting PR ... my official "first" contribution on github :-) I update my fork with your additional commit. Be prepared for the next PR; this contains the real changes (and enhancments) ....