Merge new functions - Githubissues

fcrespel / runtastic-export-converter

Command-line tool to convert Runtastic JSON export files to GPX/TCX

MIT License

1 stars 2 forks source link

Merge new functions #4

Closed ImfeldC closed 4 years ago

ImfeldC commented 4 years ago

I've further enhanced the exporter. Here a summary of the changes:

New types of export introduced (SportSessionAlbums, ImagesMetaData, Shoe incl. ShoeSize, ShoeStatistic, ShoeMilestone, User)
New option to list user data (user )
New option to list photo data (photo )
Read GPS data in GPX format file (the runtastic export contains GPS data as GPX files, starting from April-2020)
Add the related photos as "way-point" to the GPX export
Calculate bounds of sport session (consider GPS track and photos); add them as and way-points to the GPX export
Add user data as meta data to GPX export

fcrespel commented 4 years ago

Thanks for this big contribution! I haven't yet found the time to review it, but I'll definitely do that over the weekend.

ImfeldC commented 4 years ago

All review findings have been considered (except those planned as separate change requests https://github.com/fcrespel/runtastic-export-converter/issues/5 and https://github.com/fcrespel/runtastic-export-converter/issues/6). Further I added the overlap function, which allows to search for "overlapping" (=similar) sport sessions.

ImfeldC commented 4 years ago

Thanks for the valuable review feedback. I incorporated all your findings. I "try" to split future PR into smaller pieces :-) .... but in this new push is already another new function

The function "compound" searches sessions with are adjuncted to each other (e.g. if you are doing a multi day bicycle trip, you can find them). The function is not fully finished yet.

ImfeldC commented 4 years ago

All review findings incorporated. New you can pass for overlap and compound function a session id (similar to convert function). The algorithm to find compound sessions (using "bounds") is not very reliable. I need to think about a better way to calculate this; it seems I need to analyze (and compare) the tracks itself. I found several examples in my 491 sessions, where the compound (using "bounds") didn't work :-(

ImfeldC commented 4 years ago

Thanks! I'll consider your remarks when I extend/adapt the "compound" function. But this needs some "thoughts" as my initial approach didn't work well.