Closed ImfeldC closed 4 years ago
Thanks for this big contribution! I haven't yet found the time to review it, but I'll definitely do that over the weekend.
All review findings have been considered (except those planned as separate change requests https://github.com/fcrespel/runtastic-export-converter/issues/5 and https://github.com/fcrespel/runtastic-export-converter/issues/6). Further I added the overlap function, which allows to search for "overlapping" (=similar) sport sessions.
Thanks for the valuable review feedback. I incorporated all your findings. I "try" to split future PR into smaller pieces :-) .... but in this new push is already another new function
The function "compound" searches sessions with are adjuncted to each other (e.g. if you are doing a multi day bicycle trip, you can find them). The function is not fully finished yet.
All review findings incorporated. New you can pass for overlap and compound function a session id (similar to convert function). The algorithm to find compound sessions (using "bounds") is not very reliable. I need to think about a better way to calculate this; it seems I need to analyze (and compare) the tracks itself. I found several examples in my 491 sessions, where the compound (using "bounds") didn't work :-(
Thanks! I'll consider your remarks when I extend/adapt the "compound" function. But this needs some "thoughts" as my initial approach didn't work well.
I've further enhanced the exporter. Here a summary of the changes: