search

fcrespo82 / atom-markdown-table-formatter

A simple markdown plugin to format tables.
MIT License
21 stars 7 forks source link

Only works with default language-gfm grammar, should work with custom grammar #22

Closed 7k50 closed 8 years ago

7k50 commented 8 years ago

The Table Formatter doesn’t work for me. I installed it just now, so I'm not sure if it has to do with the current version of Atom or anything else.

I'm editing a .markdown file and used Dr.Drang's test table:

|Left align|Right align|Center align|
|:---------|----------:|:----------:|
|This|This|This|
|column|column|column|
|will|will|will|
|be|be|be|
|left|right|center|
|aligned|aligned|aligned|

Neither the keyboard shortcut or the context menu options work for me.

System: OS X 10.11 Atom: 1.3.1

fcrespo82 commented 8 years ago

Could you elaborate?

I'm not able to reproduce this error.

fnurl commented 8 years ago

I'm having the same issue. I open a new file, paste the table included by the OP and run the command and nothing happens. Running Atom 1.5.3 on OS X 10.11.3.

Is the package dependent on a specific syntax scope?

fcrespo82 commented 8 years ago

Sorry, but I am unable to reproduce this error.

System: Ubuntu 15.04 Atom version: gif recorded on 1.4.0, but tested on 1.5.3 as well Package version: 2.7.2

atom-markdown-table-formatter

fnurl commented 8 years ago

Ok, I found out why it does not work. If the language-gfm package is not enabled, it does not work. I use the language-markdown package which recommends turning off language-gfm. I also use other markdown packages when writing: language-pfm and atom-language-madoko.

Is it possible to remove the language-gfm dependency?

lierdakil commented 8 years ago

We could probably add config option for specifying what grammars are treated as Markdown. Just enabling it for all grammars could have unintended side effects.