fcrespo82 / atom-markdown-table-formatter

A simple markdown plugin to format tables.
MIT License
21 stars 7 forks source link

Doesn't work what so ever #37

Closed Olian04 closed 8 years ago

Olian04 commented 8 years ago

I'm not sure why, but nothing happens. I've tried both alt-shift-t as well as executing the command via the command pallet, but neither does anything.

lierdakil commented 8 years ago

Could you please provide output of 'atom --version'?

28 окт. 2016 г. 5:20 ПП пользователь "Oliver Anteros" < notifications@github.com> написал:

I'm not sure why, but nothing happens. I've tried both alt-shift-t as well as executing the command via the command pallet, but neither does anything.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fcrespo82/atom-markdown-table-formatter/issues/37, or mute the thread https://github.com/notifications/unsubscribe-auth/AG8EZv9c1XVhBgpnNyCDBHCZtTbcgMUBks5q4gSWgaJpZM4KjfWs .

dwelle commented 8 years ago

@Olian04 does the file have markdown grammar? AFAIK only works with that.

Olian04 commented 8 years ago

@lierdakil atom --version:

Atom : 1.9.9 Electron: 0.37.8 Chrome : 49.0.2623.75 Node : 5.10.0

@dwelle Grammar used: burodepeper/language-markdown

lierdakil commented 8 years ago

Try adding 'text.md' (without quotes) scope to 'markdownGrammarScopes' setting of this package. See https://github.com/fcrespo82/atom-markdown-table-formatter#settings--keybindings and below for details.

Olian04 commented 8 years ago

@lierdakil hmmm, that did it... Why?

lierdakil commented 8 years ago

Default markdown grammar in Atom uses source.gfm scope. This package detects if it should trigger for a given editor based on scope. Package you've referenced defines Markdown files as text.md scope instead. https://github.com/fcrespo82/atom-markdown-table-formatter#enable-markdown-table-formatter-for-the-current-file-type

You can thank @dwelle for asking the right question. If not for that, I would probably ask for a list of installed packages next (apm list -b).

Olian04 commented 8 years ago

@lierdakil alright, cool. Thanks :)