fcs-proj / FastCaloSim

An experiment-independent library for fast calorimeter simulation
Apache License 2.0
2 stars 0 forks source link

Add external CLHEP dependency #13

Closed jbeirer closed 5 months ago

jbeirer commented 5 months ago

This MR:

With the CLHEP usage, we switch from CLHEP::TRandomEngine() to CLHEP::RanluxEngine() as random number generator. For this reason the simulated energy deposits in basic_sim_tests change and are updated accordingly.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 19.97%. Comparing base (a6dc3d5) to head (72ebd7e).

Files Patch % Lines
source/Core/TFCSEnergyAndHitGANV2.cxx 0.00% 1 Missing :warning:
source/Core/TFCSPredictExtrapWeights.cxx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #13 +/- ## ========================================== - Coverage 20.45% 19.97% -0.49% ========================================== Files 165 159 -6 Lines 8852 8825 -27 Branches 1322 1322 ========================================== - Hits 1811 1763 -48 - Misses 7041 7062 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.