Closed jbeirer closed 5 months ago
Attention: Patch coverage is 97.77778%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 31.24%. Comparing base (
aa6344a
) to head (5139d44
).
Files | Patch % | Lines |
---|---|---|
test/TestHelpers/Container.h | 92.30% | 1 Missing :warning: |
test/TestHelpers/SimStateContainer.h | 96.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This MR:
ExtrapStateContainer
andTrackContainer
to inherit from a common base class namedContainer
. The base class is a templated class with two template parameters:ElementType
: the type of objects the container holds (e.g. TFCSSimulationState's) andSerializedType
: the struct that defines the structure of the serialized data. All daughter classes are required to override the pure virtual methodvirtual auto flatten() const -> std::vector<SerializedType> = 0;
that defines how the data is to be serialized.SimulationStateContainer
class to holdTFCSSimulationState
objects and allows its serialization. Note: Currently, the geometry / cell information does not contain all information that we would like to serialize (for instance whether a cell contains to a barrel layer and in which coordinate system its dimensions are described). This needs to be revisited once we load the geometry using the ROOT file also employed for the simplified geometry.