fcs-proj / FastCaloSim

An experiment-independent library for fast calorimeter simulation
Apache License 2.0
2 stars 0 forks source link

Fix ATLAS simplified geo #30

Closed jbeirer closed 3 months ago

jbeirer commented 3 months ago

This pull request updates the simplified geometry, now built with the proper cell dimensions (see https://github.com/jbeirer/pygeosimplify/pull/135). In the previous input:

  1. The width of barrel layers (0 - 3) dr was missing a factor 2
  2. The width of all layers dz was missing a factor 2

This was the result of an insconsistent treatment of cell sizes in the ATLAS software.

The gaps between the EMB layers now visibly disappear as expected:

ATLAS_calo_cell_dims

The resulting geometry looks as follows:

Screenshot 2024-07-08 at 19 17 43

We now get more regular transportation points in the barrel region:

Screenshot 2024-07-08 at 21 14 40
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 35.08%. Comparing base (a5d7c63) to head (1fb5d66).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #30 +/- ## ======================================= Coverage 35.08% 35.08% ======================================= Files 218 218 Lines 10575 10575 Branches 1536 1536 ======================================= Hits 3710 3710 Misses 6865 6865 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.