fcs-proj / FastCaloSim

An experiment-independent library for fast calorimeter simulation
Apache License 2.0
3 stars 1 forks source link

Add more ATLAS sim tests #33

Closed jbeirer closed 2 months ago

jbeirer commented 2 months ago

This pull request adds more ATLAS simulation tests. In addition to the barrel (η = 0.20) region we add the simulation for

In all cases, we do this for 16, 32 and 65 GeV photons and pions.

The particles to be tested are defined in AtlasSimTestsConfig.h#L31. An additional helper class ParticleSimParams.h is added to handle the particle properties and labels, etc. Due to memory considerations we do not test the simulation with a single large parametrization file, but instead use one per tested calorimeter region. The paths to the param file are stored in a std::map, mapping each region to its respective param file path in BasicSimTestsConfig.h#L12.

The tests are mainly added in preparation for https://github.com/jbeirer/FastCaloSim/pull/32, which will significantly alter how the geometry is currently handled and we hopefully can catch most of unexpected output changes with these tests.

Plots for pions looks as follows:

barrel-endcap endcap endcap-fcal fcal
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 38.07%. Comparing base (54cec1b) to head (54ca0e0). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ========================================== + Coverage 36.45% 38.07% +1.62% ========================================== Files 224 225 +1 Lines 10893 10925 +32 Branches 1557 1558 +1 ========================================== + Hits 3971 4160 +189 + Misses 6922 6765 -157 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.