search

fcsonline / node-telescope-server

A Nodejs server to control telescopes remotely, like Nexstar
Other
60 stars 23 forks source link

I emailed author a fix for Nexstar/Stellarium bogus coordinates #7

Open mgxjw opened 8 years ago

mgxjw commented 8 years ago

Hi Ferran, I sent you an email with the subject "my tested NTS fixes for the Nexstar interface". Not sure if you monitor your fcsonline@gmail.com account. Used Stellarium on Windows 8.1, Raspberry Pi 2 running nts, and Orion XT8g scope. Stellarium telescope control works well. Please take a look.

Steve

fcsonline commented 8 years ago

Awesome contribution! But could you create a pull request in Github to be reviewed, please?

mgxjw commented 8 years ago

Hi Ferran, Getting setup on GitHub now. I'm assuming you want me to create a branch off your original repository. Used other code version control software before, never github. If my understanding is correct, as long as I only work with public repositories, there is no charge.

It may take a couple of more days to get this done. Just now installed github environment on the windows machine.

Steve

On 2/2/2016 11:13 AM, Ferran Basora wrote:

Awesome contribution! But could you create a PR in Github to be reviewed, please?

— Reply to this email directly or view it on GitHub https://github.com/fcsonline/node-telescope-server/issues/7#issuecomment-178694492.

mgxjw commented 8 years ago

Created a pull request with the github web interface. Let me know if done incorrectly. Guess I didn't need to install github software on my machine.

On 2/2/2016 11:13 AM, Ferran Basora wrote:

Awesome contribution! But could you create a PR in Github to be reviewed, please?

— Reply to this email directly or view it on GitHub https://github.com/fcsonline/node-telescope-server/issues/7#issuecomment-178694492.

fcsonline commented 8 years ago

Reviewed. Could you fix the comments, please? :+1: