fcsonline / tmux-thumbs

A lightning fast version of tmux-fingers written in Rust, copy/pasting tmux like vimium/vimperator
MIT License
891 stars 61 forks source link

Default options for CLI commands (update/install) #130

Open dagadbm opened 1 year ago

dagadbm commented 1 year ago

I automate most of my dotfiles including updating them and everytime I update tmux I have to see the tmux-thumbs screen and always press option 1 (compile).

It would be nice if this CLI command could accept a default option.

something like

./tmux-thumbs-install.sh update --compile

or

./tmux-thumbs-install.sh update --download

This would make the update process silent and just compile without always having to ask if we want to update or not.

fcsonline commented 1 year ago

I'm facing the same! I will add it!

fcsonline commented 1 year ago

Thinking about it, maybe it's better to have an Environment variable to control this. What do tou think?

dagadbm commented 1 year ago

My personal opinion would just be an argument to the script.

Env variable makes me have to keep separate settings on different files (in this case zshrc needs to have a special line for a plug-in on tmux.

On Thu, Jan 5, 2023, 08:12 Ferran Basora @.***> wrote:

Thinking about it, maybe it's better to have an Environment variable to control this. What do tou think?

— Reply to this email directly, view it on GitHub https://github.com/fcsonline/tmux-thumbs/issues/130#issuecomment-1371902595, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7WGR37GUNAK2UGRHQ3EXLWQZ667ANCNFSM6AAAAAATP5N3GE . You are receiving this because you authored the thread.Message ID: @.***>

dagadbm commented 1 year ago

I thought about this a bit more and honestly anything is enough, even the env var because you can just easily prepend the command with it.

fcsonline commented 1 year ago

I have to battle test a bit more this branch but you can check it out: https://github.com/fcsonline/tmux-thumbs/pull/133

dagadbm commented 1 year ago

Is there way for me to test it locally? I don't have much experience in OSS.

Might as well try to help out how I can since you are having all the work!

On Thu, Jan 19, 2023, 21:58 Ferran Basora @.***> wrote:

I have to battle test a bit more this branch but you can check it out:

133 https://github.com/fcsonline/tmux-thumbs/pull/133

— Reply to this email directly, view it on GitHub https://github.com/fcsonline/tmux-thumbs/issues/130#issuecomment-1397663955, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD7WGR7F5GPREBJ4F7CJ4KDWTG2H5ANCNFSM6AAAAAATP5N3GE . You are receiving this because you authored the thread.Message ID: @.***>

fcsonline commented 1 year ago

You can checkout the source code and run the script passing the env variable described in the Readme.

dagadbm commented 1 year ago

Looks ok to me ;)

dagadbm commented 3 months ago

hello! just circling back on this to see if this will indeed make it to main or not.