search

fcurella / django-fakery

🏭 An easy-to-use implementation of Creation Methods for Django, backed by Faker.
http://django-fakery.readthedocs.org/en/stable/
MIT License
115 stars 6 forks source link

Tentative fix for python 3 #31

Closed arnaudlimbourg closed 7 years ago

arnaudlimbourg commented 7 years ago

Hello,

I'm upgrading a django python2 codebase to python3 (3.6.2).

When running tests (using py.test) I get the following error:

ImproperlyConfigured: Could not find the GDAL library (tried "gdal", "GDAL", "gdal2.1.0", "gdal2.0.0", "gdal1.11.0", "gdal1.10.0", "gdal1.9.0"). Is GDAL installed? If it is, try setting GDAL_LIBRARY_PATH in your settings.

It stems from the compat.py try/catch. Modifiying it like this pull request makes it work but I can't help thinking that I'm missing something.

fcurella commented 7 years ago

@arnaudlimbourg Can you rebase your branch against master? I just merged a fix for travis.

What version of django are you using?

arnaudlimbourg commented 7 years ago

@fcurella My rebase didn't quite work. Would you like me to redo the PR?

I use Django 1.11.4

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.85% when pulling a2bfbd0c2e8de8f677a77541bddf939614f2347c on arnaudlimbourg:patch-2 into 7bee4c00578d152a3ba6a053618486578a6f3e7e on fcurella:master.