search

fd0 / grobi

Automatically configure monitors/outputs for Xorg via RANDR
BSD 2-Clause "Simplified" License
126 stars 23 forks source link

Add monitor ID (derived from EDID) #11

Closed He-Ro closed 6 years ago

He-Ro commented 7 years ago

I added the monitor ID for my own use case. I also played around with changing the configuration language to HCL, but could not figure out a nice way. So I just changed the current YAML format, which can be seen in the diff for doc/grobi.conf.

You might not want to merge this as is, because it is a breaking config change. It might be best, if you switch the configuration language yourself.

I am currently running this version of grobi and it is working wonderful for my usecase (two different monitors (desktop monitor & TV) always connected via HDMI, but the TV should not be configured in a row, but in single mode). This is now doable, because I can distinguish them by their monitor ID. Now I can also add a script to execute_after to change the Pulse output to the TV, if my TV is connected.

This is of course not an extensive test and I have not tested the new code with every configuration option, but I extended all existing tests as needed.

Fixes #10

Please let me know what you think, I would like to get this merged, but I don't think that I will come up with a good way to change the configuration language on my own.

fd0 commented 6 years ago

Hey, thanks a lot for your contribution! It fell off my radar, will have a look now :)

He-Ro commented 6 years ago

I used git commit --fixup to keep the commit history clean, hope that was in your interest.

fd0 commented 6 years ago

Sure, let's not clutter the history too much.

fd0 commented 6 years ago

Thank you, great work!