search

fd0 / grobi

Automatically configure monitors/outputs for Xorg via RANDR
BSD 2-Clause "Simplified" License
126 stars 23 forks source link

Version number hard-coded as 0.5.2-dev #28

Closed pjones closed 3 years ago

pjones commented 3 years ago

The cmd_version.go file hard codes the version number as 0.5.2-dev. Therefore using the version command with grobi compiled from the v0.6.0 tag produces:

grobi 0.5.2-dev
compiled with go1.14.9 on linux

I'm not sure how golang programs normally deal with this. If you point me in the right direction I'm happy to open a PR.

fd0 commented 3 years ago

Oh, thanks for the hint. I've pushed a commit to master which hardcodes dev for now.

We used to have a program called build.go (pre Go-modules) which sets the version during compilation, but when using go build (as it is recommended in the README now) the version is not set so the one from the source is printed.