fd4s / vulcan

Functional Avro for Scala
https://fd4s.github.io/vulcan
Apache License 2.0
101 stars 34 forks source link

fix record default value cannot be a collection/map of records #605

Closed ex-ratt closed 2 months ago

ex-ratt commented 3 months ago

This fixes #592

(Is there anything else I need to add? Seems like a small enough change that it doesn't need additional explanation, or does it?)

ex-ratt commented 2 months ago

I changed the line that had the issue, hopefully it'll work now. I enabled Github actions in my fork, but it does not work, because my fork does not have any tags (line 294 in build.sbt will fail if this is the case). But here it may work, fingers crossed. If not, then I will try again.

PS: I force-pushed in order to prevent a confusing history of small fixes. Is this ok?

ayoub-benali commented 2 months ago

Thanks for the fix 👍